[Discover][APM] Detect OTEL spans for doc viewer#224439
Merged
Bluefinger merged 3 commits intoelastic:mainfrom Jun 19, 2025
Merged
[Discover][APM] Detect OTEL spans for doc viewer#224439Bluefinger merged 3 commits intoelastic:mainfrom
Bluefinger merged 3 commits intoelastic:mainfrom
Conversation
Bluefinger
added
release_note:skip
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
|
AlexGPlay
reviewed
Jun 19, 2025
...ess/profile_providers/observability/traces_document_profile/span_document_profile/profile.ts
Outdated
Show resolved
Hide resolved
AlexGPlay
approved these changes
Jun 19, 2025
Contributor
|
Starting backport for target branches: 8.19, 9.0 https://github.com/elastic/kibana/actions/runs/15762016888 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 19, 2025
## Summary This PR modifies the Span doc viewer check to be better equipped for dealing with unprocessed OTEL trace spans. If there is no `processed.event` field, we can start assuming there'd be OTEL specific fields to check. Here, we check for `kind` which *should* be present, so any value determines this to be a trace span. In the absence of `kind` being present and no `processed.event` field (just a `data_stream.type` field, we can assume it is a span regardless. ## How to test * Add the following to your `kibana.dev.yml` file: ```yaml discover.experimental.enabledProfiles: - observability-traces-data-source-profile - observability-traces-transaction-document-profile - observability-traces-span-document-profile ``` * Set up a source of unprocessed OTEL data to feed into ES (Open telemetry demo, etc) * Set your space to Observability mode, and go to Discover. * Query for `traces-*` and open any record for the document viewer * The Span Overview tab should be visible. (cherry picked from commit c88328f)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
|
Why are we backporting to 9.0 @Bluefinger? |
kibanamachine
added a commit
that referenced
this pull request
Jun 19, 2025
…24608) # Backport This will backport the following commits from `main` to `8.19`: - [[Discover][APM] Detect OTEL spans for doc viewer (#224439)](#224439) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"goncalo.rica@elastic.co"},"sourceCommit":{"committedDate":"2025-06-19T16:01:54Z","message":"[Discover][APM] Detect OTEL spans for doc viewer (#224439)\n\n## Summary\n\nThis PR modifies the Span doc viewer check to be better equipped for\ndealing with unprocessed OTEL trace spans. If there is no\n`processed.event` field, we can start assuming there'd be OTEL specific\nfields to check. Here, we check for `kind` which *should* be present, so\nany value determines this to be a trace span. In the absence of `kind`\nbeing present and no `processed.event` field (just a `data_stream.type`\nfield, we can assume it is a span regardless.\n\n\n## How to test\n\n* Add the following to your `kibana.dev.yml` file:\n```yaml\ndiscover.experimental.enabledProfiles:\n - observability-traces-data-source-profile\n - observability-traces-transaction-document-profile\n - observability-traces-span-document-profile\n```\n* Set up a source of unprocessed OTEL data to feed into ES (Open\ntelemetry demo, etc)\n* Set your space to Observability mode, and go to Discover.\n* Query for `traces-*` and open any record for the document viewer\n* The Span Overview tab should be visible.","sha":"c88328f2902564dfd283690ecfe9ed6384901837","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-infra_services","backport:version","v9.1.0","v8.19.0"],"title":"[Discover][APM] Detect OTEL spans for doc viewer","number":224439,"url":"https://github.com/elastic/kibana/pull/224439","mergeCommit":{"message":"[Discover][APM] Detect OTEL spans for doc viewer (#224439)\n\n## Summary\n\nThis PR modifies the Span doc viewer check to be better equipped for\ndealing with unprocessed OTEL trace spans. If there is no\n`processed.event` field, we can start assuming there'd be OTEL specific\nfields to check. Here, we check for `kind` which *should* be present, so\nany value determines this to be a trace span. In the absence of `kind`\nbeing present and no `processed.event` field (just a `data_stream.type`\nfield, we can assume it is a span regardless.\n\n\n## How to test\n\n* Add the following to your `kibana.dev.yml` file:\n```yaml\ndiscover.experimental.enabledProfiles:\n - observability-traces-data-source-profile\n - observability-traces-transaction-document-profile\n - observability-traces-span-document-profile\n```\n* Set up a source of unprocessed OTEL data to feed into ES (Open\ntelemetry demo, etc)\n* Set your space to Observability mode, and go to Discover.\n* Query for `traces-*` and open any record for the document viewer\n* The Span Overview tab should be visible.","sha":"c88328f2902564dfd283690ecfe9ed6384901837"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224439","number":224439,"mergeCommit":{"message":"[Discover][APM] Detect OTEL spans for doc viewer (#224439)\n\n## Summary\n\nThis PR modifies the Span doc viewer check to be better equipped for\ndealing with unprocessed OTEL trace spans. If there is no\n`processed.event` field, we can start assuming there'd be OTEL specific\nfields to check. Here, we check for `kind` which *should* be present, so\nany value determines this to be a trace span. In the absence of `kind`\nbeing present and no `processed.event` field (just a `data_stream.type`\nfield, we can assume it is a span regardless.\n\n\n## How to test\n\n* Add the following to your `kibana.dev.yml` file:\n```yaml\ndiscover.experimental.enabledProfiles:\n - observability-traces-data-source-profile\n - observability-traces-transaction-document-profile\n - observability-traces-span-document-profile\n```\n* Set up a source of unprocessed OTEL data to feed into ES (Open\ntelemetry demo, etc)\n* Set your space to Observability mode, and go to Discover.\n* Query for `traces-*` and open any record for the document viewer\n* The Span Overview tab should be visible.","sha":"c88328f2902564dfd283690ecfe9ed6384901837"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>
Contributor
Author
Oopsie, my mistake here! Removed the label |
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Jun 25, 2025
## Summary This PR modifies the Span doc viewer check to be better equipped for dealing with unprocessed OTEL trace spans. If there is no `processed.event` field, we can start assuming there'd be OTEL specific fields to check. Here, we check for `kind` which *should* be present, so any value determines this to be a trace span. In the absence of `kind` being present and no `processed.event` field (just a `data_stream.type` field, we can assume it is a span regardless. ## How to test * Add the following to your `kibana.dev.yml` file: ```yaml discover.experimental.enabledProfiles: - observability-traces-data-source-profile - observability-traces-transaction-document-profile - observability-traces-span-document-profile ``` * Set up a source of unprocessed OTEL data to feed into ES (Open telemetry demo, etc) * Set your space to Observability mode, and go to Discover. * Query for `traces-*` and open any record for the document viewer * The Span Overview tab should be visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the Span doc viewer check to be better equipped for dealing with unprocessed OTEL trace spans. If there is no
processed.eventfield, we can start assuming there'd be OTEL specific fields to check. Here, we check forkindwhich should be present, so any value determines this to be a trace span. In the absence ofkindbeing present and noprocessed.eventfield (just adata_stream.typefield, we can assume it is a span regardless.Related to #221521
How to test
kibana.dev.ymlfile:traces-*and open any record for the document viewer